Skip to content

Change 'x' argument for clarity in 'html_describe_con' internal helper 'g'#203

Open
MichaelChirico wants to merge 1 commit intoharrelfe:masterfrom
MichaelChirico:patch-1
Open

Change 'x' argument for clarity in 'html_describe_con' internal helper 'g'#203
MichaelChirico wants to merge 1 commit intoharrelfe:masterfrom
MichaelChirico:patch-1

Conversation

@MichaelChirico
Copy link
Copy Markdown
Contributor

This is being flagged by CRAN:

  html_describe_con: multiple local function definitions for ‘g’ with
    different formal arguments

I'm not sure it's the most useful CRAN flag, but OTOH, we do have x as an argument to html_describe_con and its internal helper, which is somewhat confusing. Basically we do this:

sapply(x, function(x) ...)

I think it's preferable to avoid reusing x like that, so I chose u since g above uses the same.

Alternatively, we could give these internal helpers a more descriptive name than just g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant